Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 #1448

Merged
merged 2 commits into from
Sep 21, 2023
Merged

PHP 8.3 #1448

merged 2 commits into from
Sep 21, 2023

Conversation

driesvints
Copy link
Member

No description provided.

@driesvints
Copy link
Member Author

@drbyte @mattstauffer might need your help here a bit at fixing the build for PHP 8.3

@drbyte
Copy link
Contributor

drbyte commented Sep 21, 2023

@driesvints I think if you add '[email protected]' between 'php' and '[email protected]' in the top of Brew.php in the SUPPORTED_PHP_VERSIONS array it should be good.

After 8.3 is officially released we can then also update the LATEST_PHP_VERSION constant a few lines below, but I wouldn't do that right now.

@drbyte drbyte mentioned this pull request Sep 21, 2023
@driesvints driesvints marked this pull request as ready for review September 21, 2023 19:30
@driesvints driesvints merged commit 5507867 into master Sep 21, 2023
5 checks passed
@driesvints driesvints deleted the driesvints-patch-1 branch September 21, 2023 19:30
nickygerritsen added a commit to Lets-Talk-NL/valet that referenced this pull request Dec 14, 2023
* upstream/master: (68 commits)
  Uses `actions/checkout@v4`
  Update CHANGELOG
  version
  Update CHANGELOG
  version
  Fix code styling
  Fix magento2 driver (laravel#1420)
  Update CHANGELOG
  version
  Fix code styling
  Fix code styling
  PHP 8.3 (laravel#1448)
  Update tests/CliTest.php
  Add conflict about mnapoli/silly 1.8.1–1.8.2
  Bump requirement for mnapoli/silly to 1.5+
  Add test of link command's isolate flag
  Ensure link command checks current directory for PHP version
  Improve link command's secure and isolate sub-commands
  Update CHANGELOG
  Fix code styling
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants