Allow renew() to be called without parameters #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A reasonable default is set here, consistent with the default set in other places. Fixes laravel#1464 Updates laravel#1461
|
Just manually patched my file, can confirm this resolves the error: Fatal error: Uncaught ArgumentCountError: Too few arguments to function Valet\Site::renew(), 0 passed in /Users/einarb/.composer/vendor/laravel/valet/cli/includes/facades.php on line 22 and exactly 1 expected in /Users/einarb/.composer/vendor/laravel/valet/cli/Valet/Site.php:506 Thank you! |
rognales
reviewed
Dec 30, 2023
|
Thanks! Will release this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reasonable default is set here, consistent with the default set in other places.
Fixes #1464
Updates #1461
@driesvints Can you review and consider releasing a patch, since this is a breaking bug that occurs on
valet install(which people run not only to install Valet, but also after upgrading it)