Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra parameters for share tool, fixes #1494 #1495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rcknr
Copy link
Contributor

@rcknr rcknr commented Sep 16, 2024

There was a typo in my previous PR that led to a problem passing extra arguments to share tools. Fixes #1494

@drbyte
Copy link
Contributor

drbyte commented Sep 16, 2024

Yes, that seems to be the right fix.
/cc @mattstauffer

@drbyte
Copy link
Contributor

drbyte commented Sep 16, 2024

@rcknr Can you edit your post above, and change See #1494 to Fixes #1494. That way Github will automatically close the related issue when this PR is merged (it uses the words "fixed" or "fix" or "fixes", or "closes", in the original PR post, to automatically trigger that).

@rcknr rcknr changed the title Fix extra parameters for share tool, #1494 Fix extra parameters for share tool, fixes #1494 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing arguments to Ngrok broken in v.4.8.0
2 participants