Fix spam detector handling of unreadable special characters

laravelsu · Nov 23, 2024 · 2ec13f5 · 2ec13f5
1 parent 767bb5c
commit 2ec13f5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/app/Services/SpamDetector.php b/app/Services/SpamDetector.php
@@ -105,6 +105,10 @@ public function hasTooManySpecialCharacters()
             ->squish()
             ->wordCount();
 
+        if($countWords === 0) {
+            return true;
+        }
+
         $diff = ($withSpecialCharacters - $withOutSpecialCharacters) / 2;
 
         // Proportion of special characters in the message

diff --git a/tests/Unit/SpamDetectorTest.php b/tests/Unit/SpamDetectorTest.php
@@ -144,4 +144,10 @@ public function testMessageOneSpecialCharacters(): void
         $spamDetector = new SpamDetector('🔥');
         $this->assertTrue($spamDetector->hasTooManySpecialCharacters());
     }
+
+    public function testMessageSpecialCharacters(): void
+    {
+        $spamDetector = new SpamDetector('✅ 🔤🔤🔤🔤 🔤🔤🔤🔤🔤🔤 ✅ 🔠🔠🔠🔠🔠 🔠 🔠🔠🔠🔠🔠🔠🔠 🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥 🔥🔥🔥🔥🔥 ♦️🔺🔺♦️♦️ ♦️🔺🔺🔺 4️⃣2️⃣5️⃣💲 🔡 🔡🔡🔡🔡 ⚪️⚪️🔴⚪️⚪️🔴 🔴⚪️⚪️ 🔤🔤🔤🔤🔤🔤 🔤 🔤🔤');
+        $this->assertTrue($spamDetector->hasTooManySpecialCharacters());
+    }
 }