init comment system #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Линтеры и Action не доступны, потому что репозиторий закрытый |
|
Я пока добавил просто локально psr для себя, но мы можем настроить Pint |
agoalofalife
requested changes
Nov 8, 2023
| public function store(Request $request) | ||
| { | ||
| $request->validate([ | ||
| 'commentable_type' => 'required|sometimes|string', |
There was a problem hiding this comment.
Я предпочитаю везде массив для единообразия, потому что часто, надо Rule или кастом добавлять, что думаете?
| */ | ||
| public function store(Request $request) | ||
| { | ||
| $request->validate([ |
| 'message' => 'required|string', | ||
| ]); | ||
|
|
||
| $model = $request->commentable_type::findOrFail($request->commentable_id); |
There was a problem hiding this comment.
Я конечно такую магию не особо люблю, тут комментариями хотя бы примеры добавить что может содержать
app/Models/Comment.php
Outdated
| * | ||
| * @return string | ||
| */ | ||
| protected function urlsToLink(string $text = null): string |
There was a problem hiding this comment.
Я бы переименовал в urlFromTextToHtmlUrl
app/Models/Comment.php
Outdated
| * | ||
| * @return string | ||
| */ | ||
| protected function mentionsToLink(string $text = null): string |
| * | ||
| * @return \Illuminate\Contracts\View\View | ||
| */ | ||
| public function frameForArticles(Post $post) |
| * | ||
| * @return \App\Models\Comment | ||
| */ | ||
| public function reply(Request $request, Comment $comment) |
| * | ||
| * @return \App\Models\Comment | ||
| */ | ||
| public function update(Request $request, Comment $comment) |
| @@ -16,6 +16,8 @@ class PostController extends Controller | |||
| */ | |||
| public function show(Post $post) | |||
|
|
||
| class Comment extends Model | ||
| { | ||
| use HasFactory, SoftDeletes; |
There was a problem hiding this comment.
Будем хранить эти комментарии?
There was a problem hiding this comment.
Да, для всей цепочки. Посмотрим на сколько это будет востребовано. Как вариант будем удалять если нет дочерних элементов
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена простая система комментариев с возможностью подключать не только статьи.
Нужно добавить:
Ограничить, css отступ (В будущем)