Remove unused code and documentation

larriereguichet · Apr 3, 2021 · 1625180 · 1625180
1 parent 8b161bb
commit 1625180
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 84 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -14,7 +14,7 @@ jobs:
             matrix:
                 php_version:
                     - '7.4'
-                    - '8.0'
+#                    - '8.0' TODO fix
         steps:
             -   uses: actions/checkout@v2
 
@@ -34,7 +34,7 @@ jobs:
                     coverage: pcov
                     tools: composer, php-cs-fixer, cs2pr
 
-            -   name: Run phpunit
+            -   name: Install dependencies
                 run: composer install --no-interaction
 
             -   name: Run phpunit

diff --git a/TODO.md → HISTORY.md b/TODO.md → HISTORY.md
@@ -1,8 +1,4 @@
-## Chore:
-- Allow dynamic header template in the field configuration
-- Remove dependencies between application, admin, admin view and action configuration
-
-v0.n+1:
+v1.0:
 - add filters
 - file exporters : array type, association
 - move export logic into a separate service

diff --git a/assets/js/admin.js b/assets/js/admin.js
@@ -5,40 +5,3 @@ import '../scss/admin.scss';
 const application = Application.start();
 const context = require.context("./controllers", true, /\.js$/);
 application.load(definitionsFromContext(context));
-
-
-
-// import 'jquery';
-// import 'popper.js/dist/popper';
-// import 'bootstrap/dist/js/bootstrap';
-// import 'bootstrap/dist/css/bootstrap.css';
-//
-// import '@fortawesome/fontawesome-free/js/all.js';
-// //import '@fortawesome/fontawesome-free/css/all.css';
-//
-// import '../scss/admin.scss';
-// import Collapse from "./components/Collapse";
-//
-// // Collapse
-// document.querySelectorAll('.link-toggle').forEach((element) => {
-//     let collapse = new Collapse(element);
-//     collapse.bind();
-// });
-
-// document.querySelectorAll('.dropdown-toggle').forEach(element => {
-//   console.log(element);
-//   element.addEventListener('click', event => {
-//     const targetId = element.getAttribute('id');
-//     console.log('id', targetId);
-//
-//     if (!targetId) {
-//       return;
-//     }
-//     const targets = document.querySelectorAll('[aria-labelledby="' + targetId + '"]').forEach(container => {
-//       container.classList.toggle('show');
-//       console.log(container);
-//     });
-//   });
-//
-//
-// });
diff --git a/package.json b/package.json
@@ -1,11 +1,11 @@
 {
     "devDependencies": {
+        "@symfony/ux-dropzone": "file:vendor/symfony/ux-dropzone/Resources/assets",
         "@symfony/webpack-encore": "^0.31.0",
         "core-js": "^3.6.5",
         "postcss-loader": "^3.0.0",
         "regenerator-runtime": "^0.13.7",
-        "webpack-notifier": "^1.6.0",
-        "@symfony/ux-dropzone": "file:vendor/symfony/ux-dropzone/Resources/assets"
+        "webpack-notifier": "^1.6.0"
     },
     "license": "UNLICENSED",
     "private": true,
@@ -32,4 +32,4 @@
         "tinymce": "^5.6.2",
         "tinymce-i18n": "^20.12.25"
     }
-}
+}
diff --git a/src/Form/Extension/CollectionExtensionType.php b/src/Form/Extension/CollectionExtensionType.php
@@ -4,48 +4,13 @@
 
 use Symfony\Component\Form\AbstractTypeExtension;
 use Symfony\Component\Form\Extension\Core\Type\CollectionType;
-use Symfony\Component\Form\FormInterface;
-use Symfony\Component\Form\FormView;
-use Symfony\Contracts\Translation\TranslatorInterface;
 
-/**
- * @deprecated
- */
 class CollectionExtensionType extends AbstractTypeExtension
 {
-    private TranslatorInterface $translator;
-
     public static function getExtendedTypes(): iterable
     {
         return [
             CollectionType::class,
         ];
     }
-
-//
-//    public function __construct($registry, TranslatorInterface $translator)
-//    {
-//        $this->registry = $registry;
-//        $this->translator = $translator;
-//    }
-
-    public function finishView(FormView $view, FormInterface $form, array $options)
-    {
-        // TODO remove
-//        $this->registry->register('/bundles/lagadmin/assets/admin.collection.js');
-//
-//        if (!key_exists('class', $view->vars['attr'])) {
-//            $view->vars['attr']['class'] = 'collection-container';
-//        } else {
-//            $view->vars['attr']['class'] .= ' collection-container';
-//        }
-//
-//        if ($options['allow_delete']) {
-//            $view->vars['attr']['data-remove-button'] = str_replace(
-//                '%s',
-//                $this->translator->trans('lag.admin.delete'),
-//                '<button class="remove-link btn btn-danger"><i class="fa fa-times"></i>&nbsp;%s</button>'
-//            );
-//        }
-    }
 }
diff --git a/webpack.config.js b/webpack.config.js
@@ -13,8 +13,7 @@ Encore
     .setManifestKeyPrefix('assets')
     .setPublicPath('/bundles/lagadmin')
 
-    // .addEntry('admin', './assets/js/admin.js')
-    // .addEntry('admin.collection', './assets/js/admin.collection.js')
+    // TODO remove bootstrap js
     .addEntry('js/jquery', './node_modules/jquery-easing/jquery.easing.1.3.js')
     .addEntry('js/jquery-easing', './node_modules/jquery/dist/jquery.js')
     .addEntry('js/sb-admin', './node_modules/startbootstrap-sb-admin-2/js/sb-admin-2.js')