Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itunes result debug #315

Closed
wants to merge 1 commit into from
Closed

Conversation

humanolaranja
Copy link
Contributor

The problem:
When using app flavors, you should have different app flavors with different app ids, so, maybe com.example.dev will be not available at the store, but com.example will. The problem is, when running com.example.dev, your log is flooded with this error, that is a valid error because the app id is not valid, but should not be displayed. I tried just init the upgrader if kReleaseMode, but this don't solve the issue, since the call is executed by UpgraderAlert build.
image

This PR will hide this logs the same way as in play_store_search_api and itunes_search_api:class ITunesSearchAPI

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10% ⚠️

Comparison is base (db563d2) 92.38% compared to head (21ec352) 92.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   92.38%   92.28%   -0.10%     
==========================================
  Files          11       11              
  Lines        1037     1037              
==========================================
- Hits          958      957       -1     
- Misses         79       80       +1     
Files Changed Coverage Δ
lib/src/itunes_search_api.dart 78.87% <0.00%> (-1.41%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larryaasen
Copy link
Owner

@humanolaranja Thanks for this PR. I appreciate the issue you are trying to solve, but I don't like the approach of adding a new static variable. In fact, those methods in ITunesResults should not be static anyway. I've made a change to address this and will push it into the next release. Thanks.

@larryaasen larryaasen closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants