Moved UI related code outside of Upgrader and into UpgradeAlert and UpgradeCard. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lert and UpgradeCard. Also, renamed the private methods to make them public.
…lert and UpgradeCard. Also, renamed the private methods to make them public. Added and improved example code and README.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
+ Coverage 90.27% 91.84% +1.56%
==========================================
Files 11 10 -1
Lines 1080 1091 +11
==========================================
+ Hits 975 1002 +27
+ Misses 105 89 -16 ☔ View full report in Codecov by Sentry. |
…entAppStoreVersion, and currentInstalledVersion from functions to getters.
… by the alert dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved UI related code outside of Upgrader and into UpgradeAlert and UpgradeCard.
This is the update for version 9.0.0.