Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #375 to correctly decode special characters in app titles. #376

Closed
wants to merge 1 commit into from

Conversation

aruhant
Copy link
Contributor

@aruhant aruhant commented Jan 14, 2024

This is to fix playstore parsing when app name in playstore contains special characters like apostrophe, ampersand or other unicode characters.

I have tested the changes on the following page and it seems to work correctly:
https://play.google.com/store/apps/details?id=com.mcdonalds.app

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dde6677) 90.27% compared to head (0373e14) 90.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   90.27%   90.28%           
=======================================
  Files          11       11           
  Lines        1080     1081    +1     
=======================================
+ Hits          975      976    +1     
  Misses        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larryaasen
Copy link
Owner

@aruhant Thanks for this PR. However, it does not contain a unit test. Without that, there is no way to show that this change actually fixes a problem. Can you add a unit test?

@larryaasen
Copy link
Owner

I fixed this issue and it will be available in the next release 10.1.0.

@aruhant
Copy link
Contributor Author

aruhant commented Apr 2, 2024

Thank you. If you still need help with the unit test, I'll be happy to add one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android bug Something isn't working Resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants