Updated documentation for UpgraderMessages #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it should also be mentioned that template variables can be used to update the |
larryaasen
reviewed
May 29, 2024
lib/src/upgrade_messages.dart
Outdated
| @@ -46,7 +46,7 @@ enum UpgraderMessage { | |||
| /// String get buttonTitleIgnore => 'My Ignore'; | |||
| /// } | |||
| /// | |||
| /// UpgradeAlert(messages: MyUpgraderMessages()); | |||
| /// UpgradeAlert(upgrader: Upgrader(messages: MyUpgraderMessages()); | |||
There was a problem hiding this comment.
@amarell Good catch. However, in examples, we don't like to instantiate Upgrader() in the build method so it would look better like this:
/// final upgrader = Upgrader(messages: MyUpgraderMessages());
/// ...
/// UpgradeAlert(upgrader: upgrader);
There was a problem hiding this comment.
Good point. Updated. @larryaasen
larryaasen
added
need more information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the correct way to override UpgraderMessages, right? I don't see
messagesparameter inUpgradeAlert.Probably something that changed in recent updates.