fixed Hindi localization #429
Conversation
Fixed broken braces in the body of the upgrade message. improved translations for other messages.
lib/src/upgrade_messages.dart
Outdated
| @@ -153,7 +153,7 @@ class UpgraderMessages { | |||
| break; | |||
| case 'hi': | |||
| message = | |||
| '{app name} का एक नया संस्करण उपलब्ध है। संस्करण {{currentAppStoreVersion}} अब उपलब्ध है-आपके पास है {{currentInstalledVersion}}.'; | |||
| '{{app name}} का एक नया संस्करण उपलब्ध है। आपके पास संस्करण {{currentInstalledVersion}} है, लेकिन अब {{currentAppStoreVersion}} उपलब्ध है।'; | |||
There was a problem hiding this comment.
Thanks for the PR. I like the change for the incorrect braces around app name. However, I do not like the other changes for the language text. The intent of these messages has been changed, not just simple syntax. I don't want to accept these changes unless I hear from some other Hindi speakers.
There was a problem hiding this comment.
I fixed the missing braces for app name in the code so there is no need for this PR now.
There was a problem hiding this comment.
Thank you for fixing the braces. Would you like me to submit a new PR for just the Hindi text change?
There was a problem hiding this comment.
@aruhant I would like to better understand the proposed changes first, which seem to change the meaning of the existing text.
There was a problem hiding this comment.
Alright, no problem! Those proposed changes merely use precise, more appropriate wording and do not alter the intended meaning. Though, feel free to double-check with other Hindi speakers. I am happy to clarify anything that may be unclear.
|
Came here looking for the braces bug. It changes the voice of the message from passive to active, and sounds much better as a native Hindi speaker. |
|
@aruhant I'll accept these changes now, but there is a small conflict that needs to be resolved first. |
|
I have resolved those conflicts. |
|
Thanks @aruhant - changes have been merged. |
Changes: The {{app name}} parameter of the upgrade message in Hindi had a missing set of braces around it, which was preventing it from substituting correctly. I also improved a few incorrect Hindi translations based on my proficiency as a native Hindi speaker.
Testing: Locally tested each changed string