Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master #474

Closed
wants to merge 2 commits into from
Closed

Master #474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d4ba2
Master
Nov 7, 2024
884eadc
Update upgrade_alert.dart
ArcticFox00 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lib/src/upgrade_alert.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,7 @@ class UpgradeAlertState extends State<UpgradeAlert> {
}
}

void popNavigator(BuildContext context) {
Navigator.of(context).pop();
displayed = false;
}
void popNavigator(BuildContext context) {}

bool get shouldDisplayReleaseNotes =>
widget.showReleaseNotes &&
Expand Down Expand Up @@ -236,7 +233,7 @@ class UpgradeAlertState extends State<UpgradeAlert> {
context: context,
builder: (BuildContext context) {
return PopScope(
canPop: onCanPop(),
canPop: false,
onPopInvokedWithResult: (didPop, result) {
if (widget.upgrader.state.debugLogging) {
print('upgrader: showTheDialog onPopInvoked: $didPop');
Expand Down
Loading