luks-list: show tang key thumbprints #375
Conversation
|
Sadly this disturbs the pin cfg in |
rpigott
force-pushed
the
luks-list-thp
branch
2 times, most recently
from
0a77b32
to
b3567f9
Compare
|
Ok should work now. I changed it to print the thumbprint only with a "-t" argument. |
|
Hello. Thanks for your change. Changes LGTM. Could you please complete your commit to:
Thanks |
| pin=$(printf '{"url":"%s"}' "${url}") | ||
| else | ||
| adv="$(jose fmt -j- -g adv -o- <<< "${content}")" | ||
| thp="$(jose jwk thp -i- <<< "${adv}" | tail -n1)" |
There was a problem hiding this comment.
This is not correct, as you will get thumbprints for both the exchange and signing keys. You should do something like tang-show-keys [1] does, with the jose jwk use -u verify, before getting the thumbprints.
It may be good to also specify the default hash algorithm for the thumbprints.
[1] https://github.com/latchset/tang/blob/master/src/tang-show-keys#L34
|
Hello @rpigott. May I help you uploading proposed changes? |
|
Hi, thanks for the feedback but I actually have no use for this feature anymore, so I don't really care about the patch. If you or anyone else still want this feature feel free to use or modify the patch as you see fit. |
|
@sergio-correia : do you think this is useful? Do you want me to recover it from here? |
Implements #351, adding the thp to the list output. The displayed thp can be used to fetch the specific stored key from the tang server at
GET /adv/<thp>.