Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error expansion seems to be missed in clevis-luks-report #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sarroutbi
Copy link
Collaborator

Fixes: #393

Signed-off-by: Sergio Arroutbi [email protected]

Fixes: latchset#393

Signed-off-by: Sergio Arroutbi <[email protected]>
@sarroutbi sarroutbi force-pushed the clevis_luks_report_not_returning_0 branch from 817b583 to dd63299 Compare December 2, 2022 14:28
@sarroutbi
Copy link
Collaborator Author

sarroutbi commented Dec 5, 2022

I have a doubt regarding this change, as when using "sss" there are multiple "configurations" that should be tried. If, for example, you have two "tang" servers, one of them down, should it be "ignored" to try to configure the second one?
What's your opinion, @sergio-correia , is this intentionally? If so, please let me know to close this PR without merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clevis report shows error but exits with 0
1 participant