-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include --netrc-file when calling curl #402
base: master
Are you sure you want to change the base?
Conversation
ce06b40
to
aca1550
Compare
aca1550
to
fdfed82
Compare
4d17c57
to
0023816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss the enhancement before diving into the code, but looking into the PR, I am not a fan of that harcoded /root/.netrc
-- is this feature only intended to be used by root?
Well, I don't see many cases where binding is required as "non-root" user, as it normally requires access to a device. But yes, in an ideal case, this should be passed as external argument, I agree with that. I'll try to figure out how to do this, as there is no "clevis configuration file" where this could be configured |
As this is used for encryption and decryption (also at boot time), I suggest using a configuration file under /etc. Change contemplates the possibility of this file not to exist, leaving execution intact (file can not exist, and everything will continue to work similarly) |
b838799
to
e78e752
Compare
Resolves: latchset#401 Signed-off-by: Sergio Arroutbi <[email protected]>
43f5c81
to
7e9e079
Compare
Resolves: #401
Signed-off-by: Sergio Arroutbi [email protected]