initramfs: fix killing child PIDs #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu's initramfs Busybox does not support `ps -o pid,ppid`, so fallback to unpredictable `ps -l`. In any case use `awk` to find the position of PID and PPID columns and dump appropriate child PIDs. This should be hopefully bullet-proof. Also clean-up leftover PID file. Signed-off-by: Oldřich Jedlička <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu's initramfs Busybox does not support
ps -o pid,ppid, so fallback to unpredictableps -l. In any case useawkto find the position of PID and PPID columns and dump appropriate child PIDs. This should be hopefully bullet-proof.Also clean-up leftover PID file.
Fixes issue found when running under Ubuntu's version of Busybox. Former fix #449 is not enough.
Fixes: https://bugs.launchpad.net/ubuntu/+source/clevis/+bug/2065149