Replace tarpc dependency with directly using tokio-serde #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be simpler than enclosing the entire test code with std::panic::catch_unwind. Also moves fixtures into the top-level directory. Signed-off-by: Daiki Ueno <[email protected]>
Signed-off-by: Daiki Ueno <[email protected]>
While tarpc works nicely, it pulls in a number of dependencies through its opentelemetry support, which prevents packaging the event-broker in Fedora. This switches to using tokio-serde directly for RPC. Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/tokio-serde
branch
from
695e8fb
to
fa780e9
Compare
Merged
t184256
approved these changes
Nov 20, 2023
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While tarpc works nicely, it pulls in a number of dependencies through
its opentelemetry support, which prevents packaging the event-broker
in Fedora. This switches to using tokio-serde directly for RPC.