agent: Support composite events #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/array
branch
3 times, most recently
from
29d89b0
to
ed756c1
Compare
ueno
force-pushed
the
wip/array
branch
2 times, most recently
from
dff4e8a
to
9915bd9
Compare
|
@t184256 @neverpanic now that CI is passing, could you give this a quick review? |
|
With this change, the number of probe points in GnuTLS downs to half. Before: readelf -nW lib/.libs/libgnutls.so.30 | grep 'Provider: crypto_auditing' | wc -l
33After: readelf -nW lib/.libs/libgnutls.so.30 | grep 'Provider: crypto_auditing' | wc -l
15 |
t184256
reviewed
Apr 4, 2024
ueno
force-pushed
the
wip/array
branch
2 times, most recently
from
d5df5fa
to
8fddad1
Compare
Signed-off-by: Daiki Ueno <[email protected]>
Signed-off-by: Daiki Ueno <[email protected]>
Signed-off-by: Daiki Ueno <[email protected]>
CRYPTO_AUDITING_*_DATA defines a single USDT probe point for each invocation. This causes multiple context switches to happen if they are writen in series. This adds a new macro, CRYPTO_AUDITING_DATA and CRYPTO_AUDITING_DATAV, which take an array of events to limit the number of context switches. Signed-off-by: Daiki Ueno <[email protected]>
t184256
approved these changes
Apr 9, 2024
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRYPTO_AUDITING_*_DATAdefines a single USDT probe point for eachinvocation. This causes multiple context switches to happen if they
are writen in series. This adds a new macro,
CRYPTO_AUDITING_DATAandCRYPTO_AUDITING_DATAV, which take an array of events to limitthe number of context switches.