-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: add option to allow override default default_pkcs11_module #511
meson: add option to allow override default default_pkcs11_module #511
Conversation
8dab31d
to
5031b86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are needed
8b6bc83
to
57fc9db
Compare
57fc9db
to
20c7938
Compare
I tested all combinations:
Possible configs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@simo5 looks like |
46c871d
to
3b9c319
Compare
It may have been intentional, we do support building w/o p11-kit-dev ... in which case no default would be present so now that I think of it I guess we need to allow for no defaults |
3b9c319
to
94beabb
Compare
Indeed we do support it not being defined: pkcs11-provider/src/interface.c Line 234 in 2ef2402
So I guess we need to allow an undefined defult, I guess the code needs to be:
And leave the CI with default undefined (ie revert the change to add p11-kit-dev) |
Signed-off-by: Ayoub Zaki <[email protected]>
94beabb
to
ebab1e0
Compare
@simo5: done |
Lately MacOS CI is flakier and times out, I tried to respin it and timed out again, so I am just going to ignore it for now. |
fix #510