Include parameter to indicate endpoint #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
===========================================
+ Coverage 0 58.77% +58.77%
===========================================
Files 0 4 +4
Lines 0 570 +570
Branches 0 147 +147
===========================================
+ Hits 0 335 +335
- Misses 0 134 +134
- Partials 0 101 +101 ☔ View full report in Codecov by Sentry. |
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
9 times, most recently
from
54ce3b0
to
89ad6b4
Compare
sarroutbi
changed the title
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
5 times, most recently
from
9c3b517
to
b49e1e1
Compare
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
3 times, most recently
from
0904089
to
9dba1de
Compare
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
3 times, most recently
from
7e9b597
to
38dc999
Compare
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
3 times, most recently
from
0a794e7
to
58691c1
Compare
sergio-correia
previously requested changes
Feb 9, 2024
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
from
58691c1
to
f5dd28a
Compare
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
3 times, most recently
from
26e8b86
to
086108d
Compare
sarroutbi
dismissed
sergio-correia’s stale review
Proposed changes have been implemented
sergio-correia
requested changes
Feb 12, 2024
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
2 times, most recently
from
3335e5f
to
52ef7a7
Compare
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
4 times, most recently
from
1e2eb9c
to
2bebffa
Compare
This change allows specifying -e option, so that endpoint parameter is used. This parameter gives the possibility to change URL where Tang listens, so that endpoint provided is prepended between host port information and advertisement/recovery suffix (rec/adv). Without endpoint, advertisement URL is: http://localhost:port/adv Meanwhile, if using endpoint (-e this/is/endpoint), advertisement URL is: http://localhost:port/this/is/endpoint/adv For more information, check man page Resolves: latchset#116 Signed-off-by: Sergio Arroutbi <[email protected]>
sarroutbi
force-pushed
the
202305181359_prefix_url_parameter
branch
from
2bebffa
to
f65decf
Compare
sergio-correia
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #116