Build tweaks #138
Merged
Build tweaks #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add asciidoc to dependencies so man page building is tested on all builds
Avoid meson warning
|
Looks like a quirk on rawhide. The same code ran fine literally minutes earlier. https://github.com/hdholm/tang/actions/runs/7495297550 |
Yeah, I asked it to re-run and this time it passed. |
coverage doesn't need to be checked on documentation updates either.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 57.60% 57.60%
=======================================
Files 4 4
Lines 552 552
Branches 145 145
=======================================
Hits 318 318
Misses 133 133
Partials 101 101 ☔ View full report in Codecov by Sentry. |
sergio-correia
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure man page build gets tested on all builds by adding asciidoc to dependencies and update meson command to avoid a meson warning.