Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User settings page #398

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

cfaisy
Copy link
Contributor

@cfaisy cfaisy commented Oct 25, 2021

Separate general settings and user settings and add new page for user settings.
Add theme modification in user settings.
Remove top right button for theme/log out and move it in left menu, on avatar icon. (New sub-menu for log-out and access to user settings)

@mattLLVW
Copy link
Contributor

for this kind of PR, could you please open an issue so we can discuss it first?

I don't really see the point:

  • now the user settings menu is hidden.
  • you have to look in 2 different places to manage settings.
  • the button is not working properly.

On another note, please don't add semi-colons, it add noise to the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants