Footmisc bug 19 #1701
Open
Footmisc bug 19 #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankMittelbach
requested review from
car222222,
u-fischer,
josephwright and
davidcarlisle
mbertucci47
reviewed
Mar 21, 2025
mbertucci47
reviewed
Mar 21, 2025
mbertucci47
reviewed
Mar 21, 2025
mbertucci47
reviewed
Mar 21, 2025
mbertucci47
reviewed
Mar 21, 2025
mbertucci47
reviewed
Mar 21, 2025
|
If you happen to look at the last commit @CastleStar14654 please ignore it, I must have been already asleep when I wrote that nonsense. But now it is too late and I wil fix/revert it tomorrow |
davidcarlisle
approved these changes
Mar 29, 2025
| previous behavior, they are by default both \plug{off}. One probably | ||
| wants to set them both to \plug{on} or both to \plug{off}, but for | ||
| maximum flexibility the two can be individually changed. | ||
|
|
There was a problem hiding this comment.
I (think) I'd lean towards combining these.
There was a problem hiding this comment.
it sure is possible to merge the two and in fact I'm also leaning towards that since everything else seems artifical, but without feedback I thought I stay with both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updatedThis fixes a bug reported for footmisc
FrankMittelbach/fmitex-footmisc#19
but is also present in the kernel code