Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(guides/best-practices/deployment-settings): first version 🚗 #2767

Merged
merged 7 commits into from
Jul 23, 2024
Merged

docs(guides/best-practices/deployment-settings): first version 🚗 #2767

merged 7 commits into from
Jul 23, 2024

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Apr 29, 2024

To be merged after #2764 .

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c9d6494

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@qbzzt qbzzt requested a review from alvrs May 31, 2024 03:06
alvrs
alvrs previously approved these changes Jul 3, 2024
View reviewed changes
@qbzzt qbzzt requested a review from alvrs July 3, 2024 17:26
@qbzzt
Copy link
Contributor Author

qbzzt commented Jul 3, 2024

@alvrs , can you reapprove, now I did what doesn't work in the Middle East (I resolved conflicts).

@qbzzt qbzzt changed the title docs(guides/best-practices/deployment-settings): first version docs(guides/best-practices/deployment-settings): first version 🚗 Jul 3, 2024
@holic holic merged commit 6a69b69 into main Jul 23, 2024
4 of 5 checks passed
@holic holic deleted the 240429-deploy-settings branch July 23, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@ludns ludns Awaiting requested review from ludns ludns is a code owner

@yonadaaa yonadaaa Awaiting requested review from yonadaaa

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qbzzt @holic @alvrs