Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial system manifest #2923

Closed
wants to merge 9 commits into from
Closed

feat: initial system manifest #2923

wants to merge 9 commits into from

Conversation

holic
Copy link
Member

@holic holic commented Jul 3, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 851a4ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic
holic commented Jul 4, 2024
View reviewed changes
packages/world/ts/config/v2/worldWithShorthands.ts
),
}
: null),
...(world.namespaces
Copy link
Member Author

@holic holic Jul 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous resolveWorldWithShorthands code was always setting the namespaces key, which kept the downstream resolveWorld function from determining if we're using namespaces or not.

This new logic conditionally sets the namespaces key only if it was already used.

@holic holic changed the title wip system manifest feat: initial system manifest Jul 4, 2024
@holic holic mentioned this pull request Jul 4, 2024
Merged
@holic holic closed this Aug 21, 2024
@holic
Copy link
Member Author

holic commented Aug 21, 2024

see #3050

@holic holic deleted the holic/mud-manifests branch August 21, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs Awaiting requested review from alvrs alvrs will be requested when the pull request is marked ready for review alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@holic