Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: turbo clean dependencies + gas report underflow + test snapshots #3378

Merged
merged 6 commits into from
Nov 21, 2024
Merged

fix: turbo clean dependencies + gas report underflow + test snapshots #3378

merged 6 commits into from
Nov 21, 2024

Conversation

vdrg
Copy link
Contributor

@vdrg vdrg commented Nov 20, 2024 •
edited
Loading

we need these three fixes to fix the workflow

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d8898de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vdrg vdrg marked this pull request as ready for review November 20, 2024 23:29
@vdrg vdrg changed the title fix: add clean dependencies to turbo fix: turbo clean dependencies + gas report underflow Nov 20, 2024
holic
holic reviewed Nov 21, 2024
View reviewed changes
turbo.json
"@latticexyz/world-module-erc20#clean",
"@latticexyz/world-modules#clean"
],
"cache": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so I understand, this is like an "inverse dependency"? cleaning the stuff that depends on store/world first before cleaning store/world

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly

@vdrg vdrg changed the title fix: turbo clean dependencies + gas report underflow fix: turbo clean dependencies + gas report underflow + test snapshots Nov 21, 2024
holic
holic previously approved these changes Nov 21, 2024
View reviewed changes
@vdrg vdrg merged commit 11b32fa into main Nov 21, 2024
12 checks passed
@vdrg vdrg deleted the vdrg/turbo-clean-deps branch November 21, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs left review comments

@holic holic holic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vdrg @holic @alvrs