native tls handshake: build TlsConnector in blocking threadpool #4027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openssl TlsConnector synchronously loads certificates from files. Loading these files can block for tens of milliseconds.
daviduebler
force-pushed
the
issue-4026
branch
from
2fe831b to
3eec5eb
Compare
abonander
requested changes
Sep 19, 2025
abonander
approved these changes
Sep 19, 2025
|
@daviduebler sorry, would you mind running |
daviduebler
force-pushed
the
issue-4026
branch
from
cc05033 to
976d42a
Compare
Of course. Thank you for reviewing the change! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openssl TlsConnector synchronously loads certificates from files. Loading these files can block for tens of milliseconds.
Does your PR solve an issue?
fixes #4026
Is this a breaking change?
No. It should only offload work to a different thread.