-
Couldn't load subscription status.
- Fork 3
feat: Add support for CURL networking. #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-network-request-abstraction
|
bugbot review |
64ff5eb to
417b1de
Compare
|
bugbot review |
|
bugbot review |
0564360 to
3782ee9
Compare
keelerm84
approved these changes
Oct 20, 2025
Co-authored-by: Matthew M. Keeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Add support for CURL networking.
feat: Add proxy support when using CURL networking.
END_COMMIT_OVERRIDE
This PR adds an alternate networking implementation which uses CURL instead of boost beast. Using CURL enables support for all advanced networking features including support for http, https, socks4, and socks 5 proxies.
Proxy configuration can be done using standard environment variables, or using the builder for the SDK.
CURL is used via the CURL multi interface combined with boost::asio to provide non-blocking IO. https://curl.se/libcurl/c/libcurl-multi.html
This allows for the CURL requests to be driven similarly to the boost.beast networking which is additionally supported.
CURL support is conditional based on the LD_CURL_NETWORKING CMake option. When it is enabled all HTTP/HTTPS request in the SDK use CURL. This support does not affect the redis persistence implementation.
The CI and release process has been updated to build and test the CURL and boost.Beast versions of all of the libraries. These changes constitute a non-trivial portion of the PR.
Note
Adds an optional CURL-based HTTP/SSE networking backend with proxy support, a new networking lib, and CI/release/testing to build and verify both CURL and Boost.Beast variants.
libs/networkingwithCurlMultiManagerand CURL integration (launchdarkly::networking).network::Requesterabstraction to switch between CURL and Boost.Beast.HttpProperties.Proxy) and C bindings (*_HttpProperties_Proxy); pass to SSE builder.ProxyOptions.LD_CURL_NETWORKINGto enable CURL networking;find_package(CURL QUIET)in config.LD_BUILD_COVERAGEand coverage script.install-curlaction; extend shared CI to toggle CURL builds and simulate releases (Linux/macOS/Windows).*-curlartifacts (with-experimentalsuffix for server).libs/networking.Written by Cursor Bugbot for commit f916106. This will update automatically on new commits. Configure here.