feat: Use ets for last-known server-time. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Oct 18, 2024
| @@ -46,8 +47,17 @@ send_events(Tag, Events, SummaryEvent) -> | |||
|
|
|||
| -spec get_last_server_time(Tag :: atom()) -> integer(). | |||
| get_last_server_time(Tag) -> | |||
There was a problem hiding this comment.
Instead of calling into the process this now looks up a value from ets.
kinyoklion
commented
Oct 18, 2024
| @@ -67,6 +77,7 @@ start_link(Tag) -> | |||
| {ok, State :: state()} | {ok, State :: state(), timeout() | hibernate} | | |||
| {stop, Reason :: term()} | ignore. | |||
| init([Tag]) -> | |||
| _Tid = ets:new(ets_table_name(Tag), [set, named_table, {read_concurrency, true}]), | |||
There was a problem hiding this comment.
This theoretically should be a read-heavy operation.
There was a problem hiding this comment.
If this data were large, then write_concurrency would probably be reasonable, but it is very small.
|
The contract tests cover this, but it would be nice to have some unit tests for it as well. |
|
This can be reviewed, but before release I am figuring out how to do some performance validation. |
keelerm84
approved these changes
Oct 21, 2024
kinyoklion
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## [3.4.0](v3.3.1...v3.4.0) (2024-10-24) ### Features * Add support for client-side prerequisite events. ([167308a](167308a)) * Add support for client-side visibility for all_flags_state. ([167308a](167308a)) * Use ets for last-known server-time. ([#136](#136)) ([568ac51](568ac51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses main bottleneck of #132.