feat: Add support for client-side prerequisite events. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Oct 22, 2024
priv/flags-segments-put-data.json
Outdated
There was a problem hiding this comment.
Updating this test data to have consistent clientSideAvailability with the clientSide field.
kinyoklion
commented
Oct 22, 2024
| with_reasons => boolean() | ||
| %% client_side_only => boolean(), % TODO: Support. | ||
| with_reasons => boolean(), | ||
| client_side_only => boolean() |
There was a problem hiding this comment.
It seemed reasonable to implement this at the same time, and that allows the contract tests to be passed as well.
kinyoklion
force-pushed
the
rlamb/SDK-694/add-client-side-prerequisite-events-support-to-erlang-server-sdk
branch
from
8d938aa to
f1d2e58
Compare
kinyoklion
force-pushed
the
rlamb/SDK-694/add-client-side-prerequisite-events-support-to-erlang-server-sdk
branch
from
f1d2e58 to
2e75104
Compare
kinyoklion
commented
Oct 22, 2024
| @@ -810,6 +812,101 @@ rule_match_rollout_not_in_experiment(_) -> | |||
| ExpectedEvents = ActualEvents. | |||
|
|
|||
| all_flags_state(_) -> | |||
There was a problem hiding this comment.
This test was supposed to be without reasons and the other test with reasons, but it originally had a mistake. So both tests were with reasons.
kinyoklion
commented
Oct 22, 2024
| all_flags_state_offline(_) -> | ||
| #{ | ||
| <<"$flagsState">> := #{}, | ||
| <<"$valid">> := false | ||
| } = ldclient_eval:all_flags_state(#{key => <<"userKeyA">>, kind => <<"user">>}, #{with_reasons => true}, offline). | ||
|
|
||
| all_flags_state_client_side_only(_) -> |
There was a problem hiding this comment.
New test for client-side visibility.
kinyoklion
commented
Oct 22, 2024
| FeatureStore = ldclient_config:get_value(Tag, feature_store), | ||
| AllFlags = [Flag || Flag = {_, FlagValue} <- FeatureStore:all(Tag, features), is_not_deleted(FlagValue)], | ||
| AllFlags = [Flag || Flag = {_, FlagValue} <- FeatureStore:all(Tag, features), is_not_deleted(FlagValue), is_visible(FlagValue, Options)], |
There was a problem hiding this comment.
Update the list comprehension to filter flags based on visibility.
kinyoklion
commented
Oct 22, 2024
| @@ -113,6 +113,26 @@ all_flags_state(Context, Options, Tag) -> | |||
| is_not_deleted(#{deleted := true}) -> false; | |||
| is_not_deleted(_) -> true. | |||
|
|
|||
| -spec is_prereq_of(FlagKey :: ldclient_flag:key(), Event :: ldclient_event:event()) -> boolean(). | |||
| is_prereq_of(FlagKey, #{data := #{prereq_of := PrereqOf}} = _Event) -> | |||
There was a problem hiding this comment.
If prereq_of is set to the flag we are evaluating, then that flag was evaluated as a direct prerequisite.
…vents-support-to-erlang-server-sdk
keelerm84
approved these changes
Oct 24, 2024
kinyoklion
deleted the
rlamb/SDK-694/add-client-side-prerequisite-events-support-to-erlang-server-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Add support for client-side prerequisite events.
feat: Add support for client-side visibility for all_flags_state.
END_COMMIT_OVERRIDE
SDK-803