ci: bump tested Go versions to 1.24 and 1.23 (#247)

launchdarkly · Feb 18, 2025 · c1d4eb7 · c1d4eb7
1 parent 14ff5f5
commit c1d4eb7
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 11 deletions.
diff --git a/.github/variables/go-versions.env b/.github/variables/go-versions.env
@@ -1,3 +1,3 @@
-latest=1.23
-penultimate=1.22
+latest=1.24
+penultimate=1.23
 min=1.20
diff --git a/.golangci.yml b/.golangci.yml
@@ -7,7 +7,6 @@ linters:
     - bodyclose
     - dupl
     - errcheck
-    - exportloopref
     - goconst
     - gochecknoglobals
     - gochecknoinits

diff --git a/Makefile b/Makefile
@@ -1,4 +1,4 @@
-GOLANGCI_LINT_VERSION=v1.60.1
+GOLANGCI_LINT_VERSION=v1.64.5
 
 LINTER=./bin/golangci-lint
 LINTER_VERSION_FILE=./bin/.golangci-lint-version-$(GOLANGCI_LINT_VERSION)

diff --git a/internal/concurrent.go b/internal/concurrent.go
@@ -1,8 +1,6 @@
 package internal
 
-import (
-	"sync/atomic"
-)
+import "sync/atomic"
 
 // AtomicBoolean is a simple atomic boolean type based on sync/atomic. Since sync/atomic supports
 // only integer types, the implementation uses an int32. (Note: we should be able to get rid of

diff --git a/internal/endpoints/configure_endpoints.go b/internal/endpoints/configure_endpoints.go
@@ -13,7 +13,7 @@ type ServiceType int
 const (
 	StreamingService ServiceType = iota //nolint:revive // internal constant
 	PollingService   ServiceType = iota //nolint:revive // internal constant
-	EventsService    ServiceType = iota //nolint:revive // internal constant
+	EventsService    ServiceType = iota // internal constant
 )
 
 func (s ServiceType) String() string {

diff --git a/ldcomponents/send_events.go b/ldcomponents/send_events.go
@@ -236,5 +236,5 @@ func (b *EventProcessorBuilder) DescribeConfiguration(context subsystems.ClientC
 }
 
 func durationToMillisValue(d time.Duration) ldvalue.Value {
-	return ldvalue.Float64(float64(uint64(d / time.Millisecond)))
+	return ldvalue.Float64(float64(uint64(d / time.Millisecond))) //nolint:gosec
 }
diff --git a/server_side_diagnostics.go b/server_side_diagnostics.go
@@ -105,5 +105,5 @@ func makeDiagnosticSDKData() ldvalue.Value {
 }
 
 func durationToMillis(d time.Duration) ldvalue.Value {
-	return ldvalue.Float64(float64(uint64(d / time.Millisecond)))
+	return ldvalue.Float64(float64(uint64(d / time.Millisecond))) //nolint:gosec
 }
diff --git a/subsystems/ldstoreimpl/big_segment_store_wrapper.go b/subsystems/ldstoreimpl/big_segment_store_wrapper.go
@@ -245,7 +245,7 @@ func (w *BigSegmentStoreWrapper) pollStoreAndUpdateStatus() interfaces.BigSegmen
 }
 
 func (w *BigSegmentStoreWrapper) isStale(updateTime ldtime.UnixMillisecondTime) bool {
-	age := time.Duration(uint64(ldtime.UnixMillisNow())-uint64(updateTime)) * time.Millisecond
+	age := time.Duration(uint64(ldtime.UnixMillisNow())-uint64(updateTime)) * time.Millisecond //nolint:gosec
 	return age >= w.staleTime
 }