Apply suggestions from code review

Co-authored-by: Ryan Lamb <[email protected]>
launchdarkly · Jan 28, 2025 · 904e807 · 904e807
1 parent da8caea
commit 904e807
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/shared/akamai-edgeworker-sdk/__tests__/featureStore/cacheableStore.test.ts b/packages/shared/akamai-edgeworker-sdk/__tests__/featureStore/cacheableStore.test.ts
@@ -2,7 +2,7 @@ import { EdgeProvider } from '../../src/featureStore';
 import CacheableStoreProvider from '../../src/featureStore/cacheableStoreProvider';
 import * as testData from '../testData.json';
 
-describe('CacheableStoreProvider', () => {
+describe('given a mock edge provider with test data', () => {
   const mockEdgeProvider: EdgeProvider = {
     get: jest.fn(),
   };
@@ -44,7 +44,7 @@ describe('CacheableStoreProvider', () => {
       expect(mockGet).toHaveBeenCalledTimes(1);
     });
 
-    it('prefetch does not reset', async () => {
+    it('does not reset on prefetch', async () => {
       const cacheProvider = new CacheableStoreProvider(mockEdgeProvider, 'rootKey', 0);
       await cacheProvider.get('rootKey');
       await cacheProvider.get('rootKey');

diff --git a/packages/shared/akamai-edgeworker-sdk/src/featureStore/cacheableStoreProvider.ts b/packages/shared/akamai-edgeworker-sdk/src/featureStore/cacheableStoreProvider.ts
@@ -28,7 +28,7 @@ export default class CacheableStoreProvider implements EdgeProvider {
   constructor(
     private readonly _edgeProvider: EdgeProvider,
     private readonly _rootKey: string,
-    private readonly _cacheTtlMs: number | undefined = undefined,
+    private readonly _cacheTtlMs?: number,
   ) {}
 
   /**
@@ -49,7 +49,7 @@ export default class CacheableStoreProvider implements EdgeProvider {
   }
 
   /**
-   * Fetches environment payload data from the origin in according with the caching configuration.
+   * Fetches environment payload data from the origin in accordance with the caching configuration.
    *
    * You should only call this function within a feature store to pre-fetch and cache payload data in environments
    * where its expensive to make multiple outbound requests to the origin