feat: React Native SDK major release. #369
Conversation
yusinto
requested review from
kinyoklion and
louis-launchdarkly
as code owners
|
This pull request has been linked to Shortcut Story #232775: Prep RN major release. |
| @@ -4,7 +4,7 @@ | |||
| "type": "commonjs", | |||
| "main": "./dist/index.js", | |||
| "types": "./dist/index.d.ts", | |||
| "homepage": "https://github.com/launchdarkly/js-core/tree/main/packages/shared/sdk-server", | |||
There was a problem hiding this comment.
This was a mistake and is fixed now.
| @@ -25,7 +25,7 @@ export default class Configuration { | |||
|
|
|||
| public readonly capacity = 100; | |||
| public readonly diagnosticRecordingInterval = 900; | |||
| public readonly flushInterval = 2; | |||
There was a problem hiding this comment.
Callout: I updated this to 30s because 2s seems too frequent. I double checked the iOS and Flutter SDKs also defaults to 30s.
There was a problem hiding this comment.
In the past web SDKs have been 2 seconds and mobile SDKs have been 30 seconds. Web SDKs are 2 seconds to hope to catch events due to the ephemeral nature of the browser.
This reminds me of something, which is flushing as the page closes. Which should be added to flutter. I will make a ticket.
There was a problem hiding this comment.
Ok. I'll leave this as 30s now. When we implement the react sdk, I can override to 2s in the React SDK itself. Does that sound good?
This reverts commit 4c102a5.
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk-common: 1.0.0</summary> ## [1.0.0](js-client-sdk-common-v0.2.1...js-client-sdk-common-v1.0.0) (2024-02-08) ### Features * React Native SDK major release. ([#369](#369)) ([1d5ca40](1d5ca40)) </details> <details><summary>react-native-client-sdk: 10.0.0</summary> ## [10.0.0](react-native-client-sdk-v0.2.1...react-native-client-sdk-v10.0.0) (2024-02-08) ### Features * React Native SDK major release. ([#369](#369)) ([1d5ca40](1d5ca40)) ### Bug Fixes * Fix Detox e2e tests broken after 0.73 update. ([#366](#366)) ([6349b98](6349b98)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 0.2.1 to 1.0.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Yusinto Ngadiman <[email protected]>
This prepares for the React Native SDK major release as well as the release of common/client-sdk.