feat: Add support for Payload Filtering #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Aug 26, 2024
keelerm84
force-pushed
the
mk/sc-253806/filter-param
branch
from
6d35e38 to
a53a5db
Compare
|
I reviewed and don't have any comments. Deferring to Ryan for approval since he is the js goto. |
keelerm84
force-pushed
the
mk/sc-253806/filter-param
branch
from
81bb8f6 to
437b2d0
Compare
keelerm84
commented
Aug 28, 2024
| @@ -37,6 +38,7 @@ class StreamingProcessor implements LDStreamProcessor { | |||
| sdkKey: string, | |||
| clientContext: ClientContext, | |||
| streamUriPath: string, | |||
| parameters: { key: string; value: string }[], | |||
There was a problem hiding this comment.
I put this after the URI because it felt like a better spot for it. Happy to move it if you don't like all the shifting parameters.
| @@ -1,11 +1,7 @@ | |||
| import type { Encoding, Platform, PlatformData, Requests, SdkData, Storage } from '@common'; | |||
There was a problem hiding this comment.
Linter complained about all this being unused.
kinyoklion
reviewed
Aug 28, 2024
kinyoklion
approved these changes
Aug 28, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>akamai-edgeworker-sdk-common: 1.1.14</summary> ## [1.1.14](akamai-edgeworker-sdk-common-v1.1.13...akamai-edgeworker-sdk-common-v1.1.14) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from ^2.5.0 to ^2.6.0 </details> <details><summary>akamai-server-base-sdk: 2.1.14</summary> ## [2.1.14](akamai-server-base-sdk-v2.1.13...akamai-server-base-sdk-v2.1.14) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.1.13 to ^1.1.14 * @launchdarkly/js-server-sdk-common bumped from ^2.5.0 to ^2.6.0 </details> <details><summary>akamai-server-edgekv-sdk: 1.1.14</summary> ## [1.1.14](akamai-server-edgekv-sdk-v1.1.13...akamai-server-edgekv-sdk-v1.1.14) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.1.13 to ^1.1.14 * @launchdarkly/js-server-sdk-common bumped from ^2.5.0 to ^2.6.0 </details> <details><summary>cloudflare-server-sdk: 2.5.12</summary> ## [2.5.12](cloudflare-server-sdk-v2.5.11...cloudflare-server-sdk-v2.5.12) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.3.7 to 2.3.8 </details> <details><summary>js-client-sdk-common: 1.7.0</summary> ## [1.7.0](js-client-sdk-common-v1.6.0...js-client-sdk-common-v1.7.0) (2024-09-03) ### Features * Add support for Payload Filtering ([#551](#551)) ([6f44383](6f44383)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.7.0 to 2.8.0 </details> <details><summary>js-sdk-common: 2.8.0</summary> ## [2.8.0](js-sdk-common-v2.7.0...js-sdk-common-v2.8.0) (2024-09-03) ### Features * Add support for Payload Filtering ([#551](#551)) ([6f44383](6f44383)) </details> <details><summary>js-server-sdk-common: 2.6.0</summary> ## [2.6.0](js-server-sdk-common-v2.5.0...js-server-sdk-common-v2.6.0) (2024-09-03) ### Features * Add support for Payload Filtering ([#551](#551)) ([6f44383](6f44383)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.7.0 to 2.8.0 </details> <details><summary>js-server-sdk-common-edge: 2.3.8</summary> ## [2.3.8](js-server-sdk-common-edge-v2.3.7...js-server-sdk-common-edge-v2.3.8) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.5.0 to 2.6.0 </details> <details><summary>node-server-sdk: 9.5.3</summary> ## [9.5.3](node-server-sdk-v9.5.2...node-server-sdk-v9.5.3) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.5.0 to 2.6.0 </details> <details><summary>node-server-sdk-dynamodb: 6.1.20</summary> ## [6.1.20](node-server-sdk-dynamodb-v6.1.19...node-server-sdk-dynamodb-v6.1.20) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.5.2 to 9.5.3 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.3 </details> <details><summary>node-server-sdk-otel: 1.0.12</summary> ## [1.0.12](node-server-sdk-otel-v1.0.11...node-server-sdk-otel-v1.0.12) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.5.2 to 9.5.3 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.3 </details> <details><summary>node-server-sdk-redis: 4.1.20</summary> ## [4.1.20](node-server-sdk-redis-v4.1.19...node-server-sdk-redis-v4.1.20) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.5.2 to 9.5.3 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.3 </details> <details><summary>react-native-client-sdk: 10.6.1</summary> ## [10.6.1](react-native-client-sdk-v10.6.0...react-native-client-sdk-v10.6.1) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.6.0 to 1.7.0 </details> <details><summary>vercel-server-sdk: 1.3.15</summary> ## [1.3.15](vercel-server-sdk-v1.3.14...vercel-server-sdk-v1.3.15) (2024-09-03) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.3.7 to 2.3.8 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.