fix: Fix i8n errors by adding spans to button children #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e57e12b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
yusinto
commented
Jun 3, 2025
packages/components/src/Button.tsx
Outdated
| <ProgressBar isIndeterminate aria-label="loading" className={styles.progress} /> | ||
| )} | ||
| </span> | ||
| <span>{children}</span> |
There was a problem hiding this comment.
Wrapped both ProgressBar and chidren with their own spans. I tested this locally and it seems to fix all button related i8n errors.
|
Size Change: +1 B (0%) Total Size: 526 kB
ℹ️ View Unchanged
|
nhironaka
reviewed
Jun 3, 2025
nhironaka
approved these changes
Jun 3, 2025
Niznikr
suggested changes
Jun 3, 2025
There was a problem hiding this comment.
Several visual regressions in Chromatic. I wonder if this is a worthwhile change and worth the tradeoff (more dom nodes) given it doesn't fully solve the issue as pointed out by the link you shared? That and we would have to update all the other components with similar structure as I doubt button is the only culprit.
Co-authored-by: Naomi Hironaka <[email protected]>
|
I saw your commit @Niznikr thank you! |
|
Closing in favor of #1705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://launchdarkly.atlassian.net/browse/SC-295319
The gonfalon-fe channel receives many i8n errors like so:
This is related to how the react dom gets removed/added by google translate on chrome. Read more about it here.
Related Jira issue: SC-295319: React i8n dom errors