fix: Handle unhandled errors in dev server UI (#416)

This handles errors by logging them to the console in places where we had TODO comments for error handling.
launchdarkly · Aug 29, 2024 · afe5281 · afe5281
1 parent 67cc93a
commit afe5281
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/internal/dev_server/ui/dist/index.html b/internal/dev_server/ui/dist/index.html
diff --git a/internal/dev_server/ui/src/Flags.tsx b/internal/dev_server/ui/src/Flags.tsx
@@ -44,7 +44,7 @@ function Flags({ selectedProject, flags, setFlags }: FlagProps) {
     })
       .then(async (res) => {
         if (!res.ok) {
-          return; // todo
+          throw new Error(`got ${res.status} ${res.statusText}. ${await res.text()}`)
         }
 
         const updatedOverrides = {
@@ -58,9 +58,7 @@ function Flags({ selectedProject, flags, setFlags }: FlagProps) {
 
         setOverrides(updatedOverrides);
       })
-      .catch((_e) => {
-        // todo
-      });
+      .catch( console.error.bind(console, "unable to update override"));
   };
 
   const removeOverride = (flagKey: string, updateState: boolean = true) => {
@@ -71,8 +69,6 @@ function Flags({ selectedProject, flags, setFlags }: FlagProps) {
       },
     )
       .then((res) => {
-        // todo: clean this up.
-        //
         // In the remove-all-override case, we need to fan out and make the
         // request for every override, so we don't want to be interleaving
         // local state updates. Expect the consumer to update the local state
@@ -87,9 +83,7 @@ function Flags({ selectedProject, flags, setFlags }: FlagProps) {
             setOnlyShowOverrides(false);
         }
       })
-      .catch((_e) => {
-        // todo
-      });
+      .catch( console.error.bind("unable to remove override") );
   };
 
   const fetchFlags = async () => {