chore: Remove init() #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
force-pushed
the
refactor-root-cmd
branch
from
ae05115 to
7751b73
Compare
dbolson
commented
Mar 19, 2024
| errors.Is(err, errs.ErrUnauthorized): | ||
| fmt.Fprintln(os.Stderr, err.Error()) | ||
| default: | ||
| fmt.Println(err.Error()) |
There was a problem hiding this comment.
Sneaking this in here: removes the error prefix "Error: " for messages for consistency with the more specific error strings above.
| Short: "LaunchDarkly CLI", | ||
| Long: "LaunchDarkly CLI to control your feature flags", | ||
| Version: "0.0.1", // TODO: set this based on release or use `cmd.SetVersionTemplate(s string)` | ||
| func newRootCommand() *cobra.Command { |
There was a problem hiding this comment.
Everything in init() is now in this constructor function.
k3llymariee
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the init() function because it's too magic.