-
Notifications
You must be signed in to change notification settings - Fork 0
feat(system-metrics): cpu usage #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
public struct CPUStatistics { | ||
public let user: Double | ||
public let system: Double | ||
public let idle: Double | ||
public let nice: Double | ||
public let total: Double | ||
|
||
public init(user: Double, system: Double, idle: Double, nice: Double, total: Double) { | ||
self.user = user | ||
self.system = system | ||
self.idle = idle | ||
self.nice = nice | ||
self.total = total | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
public struct SystemInfo { | ||
public var startMonitoring: () -> Void | ||
public var stopMonitoring: () -> Void | ||
|
||
public init(startMonitoring: @escaping () -> Void, stopMonitoring: @escaping () -> Void) { | ||
self.startMonitoring = startMonitoring | ||
self.stopMonitoring = stopMonitoring | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
public enum SystemMetricError: Error { | ||
case cpuLoadInfoFetchFailed | ||
case cpuLoadInfoFailed | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import MachO | ||
|
||
import System | ||
|
||
public struct CPULoad { | ||
private static let machHost = mach_host_self() | ||
private var loadPrevious = host_cpu_load_info() | ||
|
||
public init() {} | ||
|
||
private func hostCPULoadInfo() throws -> host_cpu_load_info { | ||
let hostCpuLoadInfoCount = MemoryLayout<host_cpu_load_info>.stride/MemoryLayout<integer_t>.stride | ||
var size = mach_msg_type_number_t(hostCpuLoadInfoCount) | ||
var cpuLoadInfo = host_cpu_load_info() | ||
|
||
let result = withUnsafeMutablePointer(to: &cpuLoadInfo) { | ||
$0.withMemoryRebound(to: integer_t.self, capacity: hostCpuLoadInfoCount) { | ||
host_statistics(mach_host_self(), HOST_CPU_LOAD_INFO, $0, &size) | ||
} | ||
} | ||
guard result == KERN_SUCCESS else { | ||
print("Error - \(#file): \(#function) - kern_result_t = \(result)") | ||
throw SystemMetricError.cpuLoadInfoFetchFailed | ||
} | ||
return cpuLoadInfo | ||
} | ||
|
||
/// Get CPU usage (system, user, idle, nice). Determined by the delta between the current and previous invocations. | ||
public func cpuUsage() throws -> CPUStatistics { | ||
do { | ||
let load = try hostCPULoadInfo(); | ||
let userDiff: Double = Double(load.cpu_ticks.0 - loadPrevious.cpu_ticks.0); | ||
let systemDiff = Double(load.cpu_ticks.1 - loadPrevious.cpu_ticks.1); | ||
let idleDiff = Double(load.cpu_ticks.2 - loadPrevious.cpu_ticks.2); | ||
let niceDiff = Double(load.cpu_ticks.3 - loadPrevious.cpu_ticks.3); | ||
|
||
let totalTicks = userDiff + systemDiff + idleDiff + niceDiff | ||
let system = systemDiff / totalTicks * 100.0 | ||
let user = userDiff / totalTicks * 100.0 | ||
let idle = idleDiff / totalTicks * 100.0 | ||
let nice = niceDiff / totalTicks * 100.0 | ||
|
||
return .init( | ||
user: user, | ||
system: system, | ||
idle: idle, | ||
nice: nice, | ||
total: totalTicks | ||
) | ||
} catch { | ||
throw error | ||
} | ||
} | ||
|
||
public func physicalCoresCount() -> UInt { | ||
var size: size_t = MemoryLayout<UInt>.size | ||
var coresCount: UInt = 0 | ||
sysctlbyname("hw.physicalcpu", &coresCount, &size, nil, 0) | ||
return coresCount | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: CPU Load Calculation Stuck on Initial Values
The
cpuUsage()
method calculates CPU load deltas usingloadPrevious
, butloadPrevious
is never updated with the current measurement. This causes all CPU usage calculations after the initial call to be incorrect, as they always compare against the stale, initial values.