-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: observability sdk #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0e3669
to
ed3df4e
Compare
abelonogov-ld
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are small comments but they could be fixed later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Rearchitects the SDK into modular services (logs/traces/metrics/session/crash) using OpenTelemetry exporters and new domain models, adds sampling and URLSession instrumentation, and replaces legacy modules and wiring.
DomainModels
,ApplicationServices
,OTelInstrumentation
,ObservabilityServiceLive
,iOSSessionService
, andKSCrashReportService
targets; remove legacyObservability
,Instrumentation
, andAPI/Observe
layers.Package.swift
to reflect new modules and tests.AttributeValue
,Severity
,Span
,Metric
, and updatedSemanticConvention
.ObservabilityService
(aggregatesMetricsService
,TracesService
,LogsService
),SessionService
,UserInteractionService
,CrashReportService
with asyncflush
.Options
(feature flags forlogs
/traces
/metrics
,tracingOrigins
,urlBlocklist
,customHeaders
as dict,OSLog
).LDObserve
to useObservabilityService
with concurrent access and asyncflush
.URLSession
instrumentation and span customization.user.tap
,user.swipe
).KSCrashReportService
andLDCrashFilter
that emits fatal logs viaLogsService
and awaits async flush.SamplingLive
(ExportSampler.build/customSampler
), add helpers to sample logs/spans and propagatelaunchdarkly.sampling.ratio
attribute.Observability
plugin buildsObservabilityService
, enriches resource and headers withlaunchdarkly.sdk.version
andhighlight.project_id
.EvalTracingHook
now starts/ends spans viaLDObserve
.TraceView
ends span and triggersLDObserve.shared.flush()
; config uses newOptions
flags.Written by Cursor Bugbot for commit d11f1b9. This will update automatically on new commits. Configure here.