Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Add OneNote Importer #10642

Draft
wants to merge 66 commits into
base: dev
Choose a base branch
from
Draft

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Jun 20, 2024

Summary

I'm adding a new package library that will be used to convert OneNote exports into Joplin Notes.

The onenote-converter is based on the implementations found in:
https://github.com/msiemens/one2html
https://github.com/msiemens/onenote.rs

We will be compiling the Rust code to wasm with the package wasm-pack to output a Node package that can be imported in our codebase.

Command to create node package

yarn dlx wasm-pack build ./packages/onenote-converter --target nodejs --scope joplin --debug
yarn dlx wasm-pack build ./packages/onenote-converter --target nodejs --scope joplin --release


What is missing at this point:

  • Create resources from the SVG tags after the note is converted to HTML
  • Remove the feature from mobile/app-cli. Find a way to disable the option of importing there
  • Find a way to build the onenote-converter package.
    • One option discussed was that we build the binary on CI, with "two paths", dev and prod, dev only existing on the developer machine. When the developer is making a change to the project he can modify the file pointing to the dev binary that he is building
    • Verify if we can build the package in different OS/rustup version and have the same build artifact (verify by checksum)

pedr and others added 30 commits April 1, 2024 07:15
@pedr pedr added the v3.1 label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants