Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing GitHub Enterprise Support #8

Closed
bsrz opened this issue Mar 21, 2019 · 5 comments · May be fixed by #21
Closed

Missing GitHub Enterprise Support #8

bsrz opened this issue Mar 21, 2019 · 5 comments · May be fixed by #21

Comments

@bsrz
Copy link

bsrz commented Mar 21, 2019

Would it be possible to add GitHub Enterprise support?
Maybe a field in the options view to add one or more URLs?

@lautis
Copy link
Owner

lautis commented Mar 21, 2019

In Safari extensions this is quite annoying. To my understanding, list of allowed domains must be included in a static XML file that is part of the signed binary.

<key>SFSafariWebsiteAccess</key>
<dict>
  <key>Allowed Domains</key>
  <array>
    <string>github.com</string>
    <string>gist.github.com</string>
  </array>
  <key>Include Secure Pages</key>
  <true/>
  <key>Level</key>
  <string>Some</string>
</dict>

It would be possible to include a bootstrap script on every page, and then have a script that only checks whether the extension code should be loaded or not. This would slow down (very slightly) all page loads.

I'm not currently interested in building such functionality myself. It might be easier to add your GitHub Enterprise domain to https://github.com/lautis/refined-github-safari/blob/master/Refined%20GitHub%20Extension/Info.plist and make your own builds.

@bsrz
Copy link
Author

bsrz commented Mar 25, 2019

@lautis this worked!
Thank you!

@bsrz bsrz closed this as completed Mar 25, 2019
@wearhere
Copy link

wearhere commented Oct 1, 2020

Hey @lautis , is it easier to support this using the new Safari extensions?

@lautis
Copy link
Owner

lautis commented Oct 2, 2020

I don't think it is any easier, but there might be something I'm missing. The app has not yet been ported to use the WebExtensions API available in Safari 14.

@lautis
Copy link
Owner

lautis commented Oct 17, 2020

Web extensions make this easier as there Safari has a separate control to enable an extension for a specific domain. #21 contains WIP for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants