Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop base64 gem from dependency #195

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

tricknotes
Copy link
Contributor

@tricknotes tricknotes commented Sep 21, 2024

This following warning is shown in test.

/Users/ryunosuke.sato/src/github.com/lautis/uglifier/spec/spec_helper.rb:3: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.

Instead of adding base64 to dependency, the usage of Base64#strict_encode64 and Base64#strict_decode64 have replaced with Array#pack and String#unpack1.

Note: Similar PRs are here

This following warning is shown in test.
```
/Users/ryunosuke.sato/src/github.com/lautis/uglifier/spec/spec_helper.rb:3: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.
```

Instead of adding base64 to dependency, the usage of `Base64#strict_encode64` and `Base64#strict_decode64` have replaced with `Array#pack` and `String#unpack1`.
@lautis
Copy link
Owner

lautis commented Sep 22, 2024

String#unpack1 was added in Ruby 2.4, so we'd need to bump the required ruby version to 2.4. Given hat support ended in 2019, this is OK to me.

@lautis lautis merged commit 89c6136 into lautis:master Sep 22, 2024
11 of 14 checks passed
@tricknotes tricknotes deleted the drop-base64 branch September 22, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants