Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2nd release of messaging refactor #407

Open
wants to merge 206 commits into
base: main
Choose a base branch
from
Open

2nd release of messaging refactor #407

wants to merge 206 commits into from

Conversation

killight98
Copy link

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

hexu33 and others added 30 commits August 5, 2022 12:02
@hexu33
Add submodule: pybind11
e62d846
@hexu33
Add initial abstract cpp classes declaration
4586654
@hexu33
Add multiprocessing example & document for using py_wrapper
3e50a99
@hexu33
Add License header for some code files
c267de4
@hexu33
Follow Google coding style for test/test_example.py file
789caf0
@hexu33
Update wrapper name to MessageInfrastructurePywrapper
ed172e4
@hexu33
Add alias for pointer type & use smart pointers
5265c60
@hexu33
Add message_infrastructure namespace
5548d96
@hexu33
add space betwen namespace & {
e0e09b1
@hexu33
Change py_wrapper name to message_infrastructure_py_wrapper
aa2fd5d
@hexu33
Merge pull request #292 from hexu33/messaging_refactor_develop
bceccfc 
Initialize cpp_message_infrastruture folder for development
@killight98
add cpplint dependence (#296)
f945e60 
* add cpplint dependence and add cpp scan into lint task
* ignore cpplint fail

Signed-off-by: luoxiaoc <[email protected]>
@killight98
update cpplint cmd with repository arg
2465098 
Signed-off-by: luoxiaoc <[email protected]>
@hexu33
Cpp APIs design for classes
36d8cc6
@hexu33
Merge branch 'lava-nc:messaging_refactor_develop' into messaging_refa…
81052dc 
…ctor_develop
@hexu33
fix template bug
b3302fc
@hexu33
add classes to py_module
9b8fdd7
@hexu33
Convert cpp_message_infrastructure to message_infrastructure and orig…
15e8250 
…inal message_infrastructure folder to depricated_message_infrastructure
@hexu33
Merge branch 'messaging_refactor_develop' of https://github.com/hexu3…
8458486 
…3/lava_dev into messaging_refactor_develop
@hexu33
Unify class template usage
d37c39d
@hexu33
Add abstract class details for shmem channel and ports
8cf8496 
Add abstract class details for shmem channel and ports
@hexu33
Fix cpplint warnings & errors
49ae35d 
* Add const qualifier for constant

* Fix cpplint warnings

* Modify cpplint command for new project structure

* Update ci-build.yml
@hongdami
Change project structure for message infrastracture
ffa07c8
@hexu33
Fix cpplint errors for new project structure (#302)
9096bb9
@hongdami
Update message infrastructure project folder:
c78d0ed 
1. Move csrc to message_infrastructure/csrc
2. Modify CMakeLists.txt and *_py_wrapper.cc to enable build first
3. Update ci-build.yml
@hongdami
Merge pull request #303 from hongdami/messaging_refactor_develop
d41e412 
Update message infrastructure project folder:
@killight98
Setup sub project for message_infrastructure (#305)
5ca249f 
* setup sub-project message-infrastructure
* install pybind11 by poetry

Signed-off-by: luoxiaoc <[email protected]>
@hongdami
Messaging refactor develop (#310)
fc15bbd 
* Copy the python file from depricated_message_infrastructure/*.py

* change multiprocessing.py to adapt interface

* fix cpplint error

* Update cpplib side MultiProcessing:
1. message_infrastructure_logging.h: logging for development
2. abstract_actor.h&posix_actor.cc: achieve stop function for signal
3. shm.h: Add SharedMemoryManager to cpplib
4. others: Update CMake, test and fix some type error'

fix pylint error

* Fix MultiProcessing Error and Cpplint Error

* Remove Actor interface for python

* Fix package path error

* Update API Interface
1. multiprocessing.py: Fix bug for sharedmemmanager name
2. remove lava package dependency for message_infrastructure
3. multiprocessing.cc: Add shmm and actors function
4. abstract_actor.h: Modify the posix actor and interface design
5. add and update test for multiprocessing

Signed-off-by: Miao, Hongda <[email protected]>

* Update import from message_infrastructure:
1. Move message_interface_enum.py to message_infrastructure
2. Update import syntax
3. Others: change multiprocessing init

Signed-off-by: Miao, Hongda <[email protected]>

* Update test_runtime.py import

Signed-off-by: Miao, Hongda <[email protected]>

* Update bash setenv.sh to add message_infrastructure

Signed-off-by: Miao, Hongda <[email protected]>
@seowwj @shaline-koh
Convert CppIn/Out/Ref/Var-Ports (#297)
4fe5a70 
* Adding preliminary ports

* Added CppPort and CppIOPort

* Add preliminary classes for CppInPorts and CppOutPorts

* Add preliminary code for CppRefPorts

* Added preliminary CppVarPort class

* Add derived classes for CppVarPort

* Update namespace naming

* Fix linting issues

* Updated pybind11 for numpy arrays

* Fixed cpplint issues

* Added lambda functions

* Fix linting issues in Ports.h and Abstract Port cc file

* Added Python wrapper functions

* Added Pybind dtype for AbstractPortImplementation

* Added tranformer header file

* Updated transformers with parameters

* Add missing include in PyWrapper

* Add namespace for ports.cc

* Add different types of Read()

* Add transformer include and null to constants

* Swap naming of classes in PyWrapper

* Test variant on return types

* Added Python wrapper for transformer class

* Comment out Out/Ref/VarPorts for debugging

* Change to use template for Recv and Peek (CppInPort)

* Using pointers for constants

* Updated templates for all ports

* Fixed issue with vectors

* Fix linting issue

* Uncomment in PyWrapper

* Add AbstractPort, Port and Transformer to CMakeLists

Co-authored-by: shaline-koh <[email protected]>
@hexu33 @hongdami
@killight98 @seowwj @shaline-koh
Shmem Ports & Channel refactor development (#307)
94265ef 
Signed-off-by: hexu1 <[email protected]>
Co-authored-by: Miao, Hongda <[email protected]>
Co-authored-by: Luo Xiaochuan <[email protected]>
Co-authored-by: Wen Jie Seow <[email protected]>
Co-authored-by: shaline-koh <[email protected]>
hexu33 and others added 7 commits March 27, 2023 02:50
@hexu33
Update README for msglib
f8a46d9 
Signed-off-by: Xu, He <[email protected]>
@szc321
Add probe for dds (#667)
0da8752 
* add probe feature for dds

* move two dds constructors to wraper

* add explaination comment for default nbytes

---------

Signed-off-by: szc321 <[email protected]>
@szc321 @hexu33 @killight98
Implement CppSelector (#705)
264362a 
Signed-off-by: szc321 <[email protected]>
Co-authored-by: Xu, He <[email protected]>
Co-authored-by: luoxiaoc <[email protected]>
@killight98
Enhance performacne of cpp msg lib (#709)
8c233f5 
- add SelectorSleepNs
- optimize selector based on QUBO and SNN

Signed-off-by: luoxiaoc <[email protected]>
@szc321
fix static code analysis (#710)
76227f0 
Signed-off-by: szc321 <[email protected]>
@hexu33
Merge main branch into messaging_refactor_release2nd
b94818c
@hexu33
Solve faults after merging
f5b9076 
Signed-off-by: Xu, He <[email protected]>
@hexu33 hexu33 force-pushed the messaging_refactor_release2nd branch from af35d6d to f5b9076 Compare June 19, 2023 10:15
hexu33 and others added 18 commits June 19, 2023 10:42
@hexu33
Fix static analysis issue
559f9b0 
Signed-off-by: Xu, He <[email protected]>
@szc321
fix static code analysis (#720)
db6f186 
Signed-off-by: szc321 <[email protected]>
@hexu33
Fix static analysis
3ee0379
@szc321
fix static analysis (#722)
e8a19fd 
Signed-off-by: szc321 <[email protected]>
@szc321
fix code analysis (#723)
a464897 
Signed-off-by: szc321 <[email protected]>
@szc321
fix cppcheck ignore (#724)
ede4825 
Signed-off-by: szc321 <[email protected]>
@szc321
merge main branch
8a52b8a 
Signed-off-by: szc321 <[email protected]>
@szc321
fix bugs
6a98b39 
Signed-off-by: szc321 <[email protected]>
Merge branch 'main' into release2nd_merge_main_july27
c7f88c8
Fix merge
5de3a2b 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
@mgkwill
Merge branch 'main' into messaging_refactor_release2nd
426ebea
Fix imports for watchdog
60a7b72 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Fix linting
7828613 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Fix messaging imports
22106fd 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Fix channel builder watchdog import
d1f024a 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Fix import of Channel
365b3cc 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Fix WatchdogManagerBuilder import
1260165 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
@mgkwill
Merge branch 'main' into messaging_refactor_release2nd
9ea929e
@tim-shea
Copy link
Contributor

@mgkwill @mathisrichter I propose to close this PR as not merge-able (keeping the branch of course, in case there's some code that can be rescued in the future). Is that okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexu33 hexu33 hexu33 left review comments

@briandersn briandersn briandersn left review comments

@ysingh7 ysingh7 ysingh7 left review comments

@joyeshmishra joyeshmishra joyeshmishra left review comments

@mgkwill mgkwill mgkwill left review comments

@hongdami hongdami Awaiting requested review from hongdami

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.