Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folded view #774

Merged
merged 18 commits into from
Oct 12, 2023
Merged

Folded view #774

merged 18 commits into from
Oct 12, 2023

Conversation

ymeng-git
Copy link
Contributor

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

-Support multi-instance compilation through compile_option {'folded_view': ['templateName']}

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Copy link
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please review my comments on setters and default value. We could avoid some unexpected behavior if we always require a value on setters. But most users using will not try to use them in this way and it will retain the default value.

src/lava/magma/core/process/process.py Show resolved Hide resolved
src/lava/magma/core/process/process.py Show resolved Hide resolved
@ymeng-git ymeng-git merged commit d094e69 into main Oct 12, 2023
6 checks passed
@mgkwill mgkwill deleted the folded_view branch October 12, 2023 18:43
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* added the folded_view compilation option and propagated folded_views
* enable folded compilation for dynamically created workloads

---------

Co-authored-by: Marcus G K Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants