Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit gracefully when trying to build in a directory without configuration file. #67

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Bzero
Copy link
Contributor

@Bzero Bzero commented Dec 5, 2024

A small PR to ensure a graceful exit and provide some feedback on why building failed when trying to do it in a directory missing a configuration file.

@lawmurray
Copy link
Owner

Thanks for this one @Bzero. Let me review.

I recall wanting, in the past, to allow doxide to run without a configuration file for trivial cases, but this might be misguided now as features have expanded, and this seems an opportune time to revisit.

@lawmurray lawmurray self-assigned this Dec 19, 2024
@Bzero
Copy link
Contributor Author

Bzero commented Dec 19, 2024

I see, in this case feel free to reject this PR if you decide to fall back to some default when there is no configuration file.

Added a suggested action to error message.
@lawmurray lawmurray merged commit 3708d3c into lawmurray:main Jan 21, 2025
0 of 3 checks passed
@lawmurray
Copy link
Owner

Let me merge this one too @Bzero, better to err on the side of not creating files when run in the wrong directory I think. I extended the actual error message displayed to suggest an action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants