Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List typedefs on parent page. #70

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

Bzero
Copy link
Contributor

@Bzero Bzero commented Jan 3, 2025

This pull request moves the details of typedef statements from their separate pages to a details section in the parents page in the same way as functions, variables, macros, etc. are handled and resolves #35.

src/CppParser.cpp Show resolved Hide resolved
@lawmurray
Copy link
Owner

Nice, thanks @Bzero, will review.

@lawmurray lawmurray merged commit 74e4a77 into lawmurray:main Jan 6, 2025
3 checks passed
@lawmurray
Copy link
Owner

Looks good @Bzero, now merged. I made a very minor change, making the headings read just "Type Aliases" rather than "Typedefs and Type Aliases", for brevity, given "Type Alias" is the more modern term.

Thanks again for these contributions, really appreciate the improvements that you've made here. I'll get a new release out with your recent changes soon.

@Bzero
Copy link
Contributor Author

Bzero commented Jan 6, 2025

Looks good @Bzero, now merged. I made a very minor change, making the headings read just "Type Aliases" rather than "Typedefs and Type Aliases", for brevity, given "Type Alias" is the more modern term.

Thanks, yes the former headings were a bit long.

Thanks again for these contributions, really appreciate the improvements that you've made here. I'll get a new release out with your recent changes soon.

Very welcome, I am glad to contribute where I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: should typedef get a separate page?
2 participants