Merge pull request #1616 from laws-africa/commencements-bug-fix

Guard against objects without `commencements_json` attribute
laws-africa · Nov 8, 2023 · 58fdd44 · 58fdd44
2 parents 0cbc91a + 14892a8
commit 58fdd44
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/peachjam/adapters/adapters.py b/peachjam/adapters/adapters.py
@@ -395,22 +395,23 @@ def fetch_relationships(self, imported_document, created_document):
                         object_work=amending_work,
                     )
 
-        commencements = created_document.commencements_json
-        if commencements:
-            for commencement in commencements:
-                if (
-                    commencement["commencing_frbr_uri"]
-                    and commencement["commencing_title"]
-                ):
-                    commencing_work, _ = Work.objects.get_or_create(
-                        frbr_uri=commencement["commencing_frbr_uri"],
-                        defaults={"title": commencement["commencing_title"]},
-                    )
-                    self.create_relationship(
-                        "commenced-by",
-                        subject_work=subject_work,
-                        object_work=commencing_work,
-                    )
+        if hasattr(created_document, "commencements_json"):
+            commencements = created_document.commencements_json
+            if commencements:
+                for commencement in commencements:
+                    if (
+                        commencement["commencing_frbr_uri"]
+                        and commencement["commencing_title"]
+                    ):
+                        commencing_work, _ = Work.objects.get_or_create(
+                            frbr_uri=commencement["commencing_frbr_uri"],
+                            defaults={"title": commencement["commencing_title"]},
+                        )
+                        self.create_relationship(
+                            "commenced-by",
+                            subject_work=subject_work,
+                            object_work=commencing_work,
+                        )
         logger.info(f"Fetching of relationships for {subject_work} is complete!")
 
     def create_relationship(self, slug, subject_work, object_work):