keep it simple: subclass AttachmentAbstractModel

peachjam/models/core_document_model.py

@@ -896,7 +896,7 @@ def save(self, *args, **kwargs):
             self.set_download_filename()
 
 
-class PublicationFile(SourceFile):
+class PublicationFile(AttachmentAbstractModel):
     SAVE_FOLDER = "publication_file"
 
     document = models.OneToOneField(
@@ -905,6 +905,9 @@ class PublicationFile(SourceFile):
         on_delete=models.CASCADE,
         verbose_name=_("document"),
     )
+    source_url = models.URLField(
+        _("source URL"), max_length=2048, null=True, blank=True
+    )
     trusted_url = models.URLField(
         _("trusted URL"), max_length=2048, null=True, blank=True
     )
@@ -913,24 +916,6 @@ class Meta:
         verbose_name = _("publication file")
         verbose_name_plural = _("publication files")
 
-    def as_pdf(self):
-        # assume the publication file is a PDF; if not, ignore it
-        if self.mimetype == "application/pdf":
-            return self.file
-        return None
-
-    def convert_to_pdf(self):
-        # don't convert anything
-        pass
-
-    def ensure_file_as_pdf(self):
-        # don't convert anything
-        pass
-
-    def filename_for_download(self, ext=None):
-        filename = super().filename_for_download(ext=ext)
-        return "Publication file: " + filename
-
 
 class AttachedFileNature(models.Model):
     name = models.CharField(