correct padding and margins around entity profiles

breadcrumbs must have padding at the top, and margin below (which can collapse into margins of the h1 on the page, if necessary)
laws-africa · Sep 5, 2024 · 787ae48 · 787ae48
1 parent 0b1c8d3
commit 787ae48
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 14 deletions.
diff --git a/africanlii/templates/africanlii/au_institution_detail.html b/africanlii/templates/africanlii/au_institution_detail.html
@@ -24,7 +24,7 @@
 {% block entity-profile %}
   {% with entity_profile=author.au_institution.entity_profile.first entity_profile_title=author.name %}
     {% if entity_profile %}
-      <div class="mt-3">{% include 'peachjam/_entity_profile.html' %}</div>
+      {% include 'peachjam/_entity_profile.html' %}
     {% endif %}
   {% endwith %}
 {% endblock %}

diff --git a/africanlii/templates/africanlii/au_organ_detail.html b/africanlii/templates/africanlii/au_organ_detail.html
@@ -23,7 +23,7 @@
 {% block entity-profile %}
   {% with entity_profile=author.au_organ.entity_profile.first entity_profile_title=author.name %}
     {% if entity_profile %}
-      <div class="mt-3">{% include 'peachjam/_entity_profile.html' %}</div>
+      {% include 'peachjam/_entity_profile.html' %}
     {% endif %}
   {% endwith %}
 {% endblock %}
diff --git a/africanlii/templates/africanlii/member_state_detail.html b/africanlii/templates/africanlii/member_state_detail.html
@@ -24,7 +24,7 @@
 {% block entity-profile %}
   {% with entity_profile=member_state.entity_profile.first entity_profile_title=member_state.name %}
     {% if entity_profile %}
-      <div class="mt-3">{% include 'peachjam/_entity_profile.html' %}</div>
+      {% include 'peachjam/_entity_profile.html' %}
     {% endif %}
   {% endwith %}
 {% endblock %}

diff --git a/africanlii/templates/africanlii/regional_economic_community_detail.html b/africanlii/templates/africanlii/regional_economic_community_detail.html
@@ -24,7 +24,7 @@
 {% block entity-profile %}
   {% with entity_profile=rec.entity_profile.first entity_profile_title=rec.name %}
     {% if entity_profile %}
-      <div class="mt-3">{% include 'peachjam/_entity_profile.html' %}</div>
+      {% include 'peachjam/_entity_profile.html' %}
     {% endif %}
   {% endwith %}
 {% endblock %}

diff --git a/peachjam/static/stylesheets/_global.scss b/peachjam/static/stylesheets/_global.scss
@@ -92,11 +92,6 @@ footer {
   }
 }
 
-.breadcrumb {
-  padding-top: 1rem;
-  margin-bottom: 0;
-}
-
 // xs btn
 .btn.btn-xs {
   @include button-size(0.125rem, 0.25rem, $btn-font-size-sm, $btn-border-radius-sm);
@@ -194,3 +189,7 @@ a:visited {
 #skip-links a:focus {
   top: -1px;
 }
+
+.breadcrumb {
+  padding-top: 1rem;
+}
diff --git a/peachjam/static/stylesheets/_variables.scss b/peachjam/static/stylesheets/_variables.scss
@@ -28,3 +28,5 @@ $visited-link: #1A77F2 !default;
   --diff-green-color: #{$diff-green-color};
   --diff-red-color: #{$diff-red-color};
 }
+
+$breadcrumb-margin-bottom: 1rem !default;
diff --git a/peachjam/static/stylesheets/components/_entity-profile.scss b/peachjam/static/stylesheets/components/_entity-profile.scss
@@ -1,7 +1,6 @@
 .entity-profile {
   @extend .bg-light;
-
-  margin-top: -1rem;
+  margin-bottom: 1rem;
 
   &.has-background-photo {
     background-color: transparent !important;

diff --git a/peachjam/templates/peachjam/court_detail.html b/peachjam/templates/peachjam/court_detail.html
@@ -37,7 +37,7 @@
 {% block entity-profile %}
   {% with entity_profile=court.entity_profile.first entity_profile_title=court.name %}
     {% if entity_profile %}
-      <div class="mt-3">{% include 'peachjam/_entity_profile.html' %}</div>
+      {% include 'peachjam/_entity_profile.html' %}
     {% endif %}
   {% endwith %}
 {% endblock %}

diff --git a/peachjam/templates/peachjam/layouts/document_list.html b/peachjam/templates/peachjam/layouts/document_list.html
@@ -7,7 +7,7 @@
   {% block breadcrumbs %}{% endblock %}
   {% block entity-profile %}
     {% if entity_profile %}
-      <div class="mt-3">{% include 'peachjam/_entity_profile.html' %}</div>
+      {% include 'peachjam/_entity_profile.html' %}
     {% endif %}
   {% endblock %}
   <div class="container pb-5" data-component="DocumentList">

diff --git a/peachjam/templates/peachjam/taxonomy_detail.html b/peachjam/templates/peachjam/taxonomy_detail.html
@@ -26,7 +26,7 @@
 {% block entity-profile %}
   {% if entity_profile %}
     {% with entity_profile_title=taxonomy.name %}
-      <div class="mt-3">{% include 'peachjam/_entity_profile.html' %}</div>
+      {% include 'peachjam/_entity_profile.html' %}
     {% endwith %}
   {% endif %}
 {% endblock %}