fix PDF downloads; fixes #1930

laws-africa · Jul 24, 2024 · ee7084f · ee7084f
1 parent eda8e52
commit ee7084f
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/peachjam/views/documents.py b/peachjam/views/documents.py
@@ -116,17 +116,17 @@ def render_to_response(self, context, **response_kwargs):
             if source_file.source_url and source_file.mimetype == "application/pdf":
                 return redirect(source_file.source_url)
 
-            if getattr(source_file.file.storage, "custom_domain", None):
-                # use the storage's custom domain to serve the file
-                return redirect(source_file.file.url)
-
             pdf = source_file.as_pdf()
             if pdf:
-                return self.make_response(
-                    pdf,
-                    "application/pdf",
-                    source_file.filename_for_download(".pdf"),
-                )
+                if getattr(pdf.storage, "custom_domain", None):
+                    # use the storage's custom domain to serve the file
+                    return redirect(pdf.url)
+                else:
+                    return self.make_response(
+                        pdf,
+                        "application/pdf",
+                        source_file.filename_for_download(".pdf"),
+                    )
         raise Http404()